Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testnet flags to combine command #2838

Closed
xenowits opened this issue Jan 29, 2024 · 1 comment · Fixed by #2856
Closed

Add testnet flags to combine command #2838

xenowits opened this issue Jan 29, 2024 · 1 comment · Fixed by #2856
Assignees
Labels
protocol Protocol Team tickets

Comments

@xenowits
Copy link
Contributor

🎯 Problem to be solved

The current charon combine command doesn't support testnet flags and errors like the below:

charon-distributed-validator-cluster % docker run -u $(id -u):$(id -g) --rm -v "$(pwd)/:/opt/charon" obolnetwork/charon:v0.19.1-rc1 combine    
12:17:55.905 INFO cmd        Recombining private key shares           {"input_dir": "/opt/charon/.charon/cluster", "output_dir": "/opt/charon/validator_keys"}
12:17:55.918 ERRO cmd        Fatal error: cannot open manifest file: manifest load error: load dag from disk: couldn't load cluster from legacy lock file: cluster lock signature verification failed. Run with --no-verify to bypass verification at own risk: invalid definition: invalid fork version {"name": "node0", "fork_version": "0x10000038"}
        eth2util/network.go:110 .networkFromForkVersion
        eth2util/network.go:115 .ForkVersionToChainID
        cluster/eip712sigs.go:74 .digestEIP712
        cluster/definition.go:182 .VerifySignatures
        cluster/lock.go:145 .VerifySignatures
        cmd/combine/combine.go:268 .verifyLock
        cmd/combine/combine.go:230 .func1
        cluster/manifest/load.go:103 .loadDAGFromLegacyLock
        cluster/manifest/load.go:47 .LoadDAG
        cluster/manifest/load.go:26 .LoadCluster
        cmd/combine/combine.go:229 .loadManifest
        cmd/combine/combine.go:61 .Combine
        cmd/combine.go:51 .newCombineFunc
        cmd/combine.go:28 .func1
        cmd/cmd.go:80 .func1
        main.go:19 .main

🛠️ Proposed solution

Add testnet flags to the charon combine command.

@github-actions github-actions bot added the protocol Protocol Team tickets label Jan 29, 2024
@dB2510
Copy link
Contributor

dB2510 commented Jan 31, 2024

Hey team! Please add your planning poker estimate with Zenhub @dB2510 @gsora @pinebit @xenowits

obol-bulldozer bot pushed a commit that referenced this issue Feb 6, 2024
Add `--testnet-*` flags to `combine` command.

Users must specify custom network name, chain ID genesis timestamp and fork version as hex string to allow for a custom testnet configuration to work.

category: bug
ticket: #2838 

Closes #2838.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants