Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: fix test-related data race #2763

Closed
gsora opened this issue Dec 21, 2023 · 0 comments · Fixed by #2869
Closed

p2p: fix test-related data race #2763

gsora opened this issue Dec 21, 2023 · 0 comments · Fixed by #2869
Labels
protocol Protocol Team tickets

Comments

@gsora
Copy link
Collaborator

gsora commented Dec 21, 2023

🐞 Bug Report

Description

There is a low-consequences data race happening in the p2p package: https://github.com/ObolNetwork/charon/actions/runs/7289045255/job/19862855243?pr=2762#step:5:2191.

This issue can be fixed by synchronizing access to peerState.buffer.

🔬 Minimal Reproduction

Run integration tests with a high -count value.

🔥 Error

https://github.com/ObolNetwork/charon/actions/runs/7289045255/job/19862855243?pr=2762#step:5:2191
@github-actions github-actions bot added the protocol Protocol Team tickets label Dec 21, 2023
This was referenced Feb 8, 2024
Closed
Merged
obol-bulldozer bot pushed a commit that referenced this issue Feb 8, 2024
@gsora
*: fix flappy tests (#2869)
24d8cc1 
This PR:
 - fixes a data race in p2p.Sender which was flapping in integration and compose tests
 - makes "prepare round 2, decide round 3" QBFT internal test more reliable; tested empirically by running the test 100.000 times, usually the flapping issue manifested itself after a couple runs

category: bug
ticket: #2763

Closes #2763.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: fix flappy tests ObolNetwork/charon
1 participant
@gsora