Skip to content

Commit

Permalink
core: remove todo (#2957)
Browse files Browse the repository at this point in the history
Remove unimplemented function in `transport` package.

category: misc
ticket: none
  • Loading branch information
xenowits authored Mar 14, 2024
1 parent 66b41d7 commit d109507
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions core/consensus/transport.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"google.golang.org/protobuf/types/known/timestamppb"

"github.com/obolnetwork/charon/app/errors"
"github.com/obolnetwork/charon/app/log"
"github.com/obolnetwork/charon/core"
pbv1 "github.com/obolnetwork/charon/core/corepb/v1"
"github.com/obolnetwork/charon/core/qbft"
Expand Down Expand Up @@ -144,11 +143,6 @@ func (t *transport) ProcessReceives(ctx context.Context, outerBuffer chan msg) {
case <-ctx.Done():
return
case msg := <-outerBuffer:
if err := validateMsg(msg); err != nil {
log.Warn(ctx, "Dropping invalid message", err)
continue
}

t.setValues(msg)

select {
Expand Down Expand Up @@ -196,12 +190,6 @@ func createMsg(typ qbft.MsgType, duty core.Duty,
return newMsg(pbMsg, justMsgs, values)
}

// validateMsg returns an error if the message is invalid.
func validateMsg(_ msg) error {
// TODO(corver): implement (incl signature verification).
return nil
}

// newSniffer returns a new sniffer.
func newSniffer(nodes, peerIdx int64) *sniffer {
return &sniffer{
Expand Down

0 comments on commit d109507

Please sign in to comment.