Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Executable Argument Parsing #99

Merged
merged 10 commits into from
Sep 17, 2024
Merged

Conversation

ObliviousHarmony
Copy link
Owner

@ObliviousHarmony ObliviousHarmony commented Sep 17, 2024

All Submissions:

  • Have you checked for duplicate PRs?
  • Have you added an entry to the CHANGELOG.md file's [Unreleased] section?

Changes proposed in this Pull Request:

This pull request adds the split-string package to replace the regex parsing of executable paths. This will provide more comprehensive quoting behavior across operating systems and better cover Windows paths.

Closes #97.

How to test the changes in this Pull Request:

  1. Add arguments to an executable option.
  2. Confirm that they work correctly.

@ObliviousHarmony
Copy link
Owner Author

After further debugging, it actually looks like this backward-incompatible change is the main culprit. I'm still going to keep the nice argument parser because it's a more comprehensive solution, however, I've followed the advice of the CVE for a fix.

@ObliviousHarmony ObliviousHarmony merged commit 28fc7c7 into main Sep 17, 2024
2 checks passed
@ObliviousHarmony ObliviousHarmony deleted the fix/97-windows-paths branch September 17, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path to windows executable can't handle spaces
1 participant