Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosened Some Configuration Scopes #90

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Loosened Some Configuration Scopes #90

merged 2 commits into from
Jan 26, 2024

Conversation

ObliviousHarmony
Copy link
Owner

@ObliviousHarmony ObliviousHarmony commented Jan 26, 2024 •
edited
Loading

All Submissions:

  • Have you checked for duplicate PRs?
  • Have you added an entry to the CHANGELOG.md file's [Unreleased] section?

Changes proposed in this Pull Request:

I made an incorrect assumption that "window" applied to each individual folder in a multi-root workspace. This is not true and the scope that achieves that should be "resource". This PR changes the scope on some of those settings.

Closes #88.

How to test the changes in this Pull Request:

  1. Make sure that the extension still works as-is.
  2. Check that the extension works in a multi-root workspace and uses the correct PHPCS and configuration.

@ObliviousHarmony ObliviousHarmony merged commit 0422ba8 into main Jan 26, 2024
2 checks passed
@ObliviousHarmony ObliviousHarmony deleted the enhance/change-configuration-scopes branch January 26, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow folder settings for standard and standardCustom
1 participant
@ObliviousHarmony