Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Document Change & Save Handling #84

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

ObliviousHarmony
Copy link
Owner

All Submissions:

  • Have you checked for duplicate PRs?
  • Have you added an entry to the CHANGELOG.md file's [Unreleased] section?

Changes proposed in this Pull Request:

Previously there was a problem where document saves would squash the debounce for updates with a different event. There isn't really a reason to debounce the save handler and so I've separated the two handlers.

How to test the changes in this Pull Request:

  1. Make sure linting on save works.
  2. Make sure linting on change works.
  3. Make sure linting on open works.

Since we were using a debounce in both cases the save
event would squash the change event. This could lead to
cases where diagnostics wouldn't refresh after a save.
@ObliviousHarmony ObliviousHarmony merged commit b56a652 into main Nov 8, 2023
2 checks passed
@ObliviousHarmony ObliviousHarmony deleted the fix/lint-action-debounce-contention branch November 8, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant