Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Diagnostics on Configuration Changes #80

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

ObliviousHarmony
Copy link
Owner

All Submissions:

  • Have you checked for duplicate PRs?
  • Have you added an entry to the CHANGELOG.md file's [Unreleased] section?

Changes proposed in this Pull Request:

Since the output might change as a result of configuration
adjustments we should clear the diagnostics. This keeps
us from displaying incorrect information.

Closes #72.

How to test the changes in this Pull Request:

  1. Open a project and create a diagnostic error.
  2. Break the configuration and observe clearing.
  3. Change the PHPCS file and observe clearing.

Since the output might change as a result of configuration
adjustments we should clear the diagnostics. This keeps
us from displaying incorrect information.
@ObliviousHarmony ObliviousHarmony merged commit e6c6c0c into main Nov 7, 2023
2 checks passed
@ObliviousHarmony ObliviousHarmony deleted the fix/72 branch November 7, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics Not Erased On Configuration Or FileSystemWatcher Changes
1 participant