Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Diagnostics On Unacceptable Exceptions #79

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

ObliviousHarmony
Copy link
Owner

All Submissions:

  • Have you checked for duplicate PRs?
  • Have you added an entry to the CHANGELOG.md file's [Unreleased] section?

Changes proposed in this Pull Request:

We should be clearing diagnostic information when we throw
exceptions that we did not accept. This prevents some
diagnostics to be left behind when they shouldn't be.

Closes #71.

How to test the changes in this Pull Request:

  1. Open a project with a working PHPCS extension configuration.
  2. Make sure that there are visible errors in a document.
  3. Break the configuration, such as by turning off autoExecutable and entering an invalid executable.

We should be clearing diagnostic information when we throw
exceptions that we did not accept. This prevents some
diagnostics to be left behind when they shouldn't be.
@ObliviousHarmony ObliviousHarmony merged commit 8f4e294 into main Nov 7, 2023
2 checks passed
@ObliviousHarmony ObliviousHarmony deleted the fix/71 branch November 7, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics Not Erased On Error
1 participant