Variable Shadowing Bug in leccalc/aggreports.cpp (Lines 1312-1315)

[FangWeihua]

Issue Description

In the file leccalc/aggreports.cpp, at lines 1312‑1315, there is a variable shadowing issue that leads to the fileIDs vector remaining empty after the conditional block.

std::vector<int> fileIDs;  // Outer declaration
if (outputFlags_[handles[WHEATSHEAF]] == true) {
    std::vector<int> fileIDs = GetFileIDs(handles[WHEATSHEAF], PSEPT);  // Inner declaration – shadows the outer one
}
// Here 'fileIDs' is still empty

The code currently declares std::vector<int> fileIDs outside an if block, then inside the block re‑declares a new local variable with the same name (std::vector<int> fileIDs = ...).

This local variable inside the if scope is destroyed when the block ends, leaving the outer fileIDs unchanged (still empty). Later code that depends on fileIDs being populated will therefore fail or behave incorrectly.

Expected behavior
The inner assignment should modify the outer fileIDs variable, not create a new local one.

[benhayes21]

Hi @FangWeihua

Thanks for the issue. We are in the process of winding down ktools since Oasis will be moving to PyTools, the python version of the calculation engine components from the end of this month.

While we will continue to support ktools to some extent (since it will still be used in the LTS versions of Oasis), fixes will not be actively worked on unless they are critical. If you would like to explain the effect of this issue in a little more detail and why you think it should be corrected then please feel free and we will consider a fix. Alternatively, as ktools is an open source project, if you'd like to contribute the fix back yourself then we can review and merge it.

Thanks,
Ben