fix: prune commit bug and add store watcher tests#35
Merged
Conversation
Python's sqlite3 module starts an implicit transaction on DELETE even when zero rows match. Without an unconditional commit, the open write transaction blocks other connections to the same database. Also add tests for multi-connection store watcher and handler exception isolation.
Oaklight
force-pushed
the
worktree-feat+33-store-watcher
branch
from
3667ce9 to
07460fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #34.
_prune_locked()not committing when zero rows are deleted, which left an implicit write transaction open and blocked other SQLite connections to the same databasetest_external_writer_with_store_watcher— simulates MCP server writing to shared db while SDK store watcher readstest_handler_exception_does_not_block_others— verifies a failing handler doesn't prevent other handlers from receiving messagesTest plan