-
Notifications
You must be signed in to change notification settings - Fork 1.2k
SonarQube report as Java class #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonarQube report as Java class #299
Conversation
(result -> hotspots.addAll(result.hotspots))); | ||
|
||
writeStringToFile( | ||
new File("results/" + resultFilename() + ".json"), |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High test
user-provided value
(result -> hotspots.addAll(result.hotspots))); | ||
|
||
writeStringToFile( | ||
new File("results/" + resultFilename() + ".json"), |
Check failure
Code scanning / CodeQL
File Path Injection Error test Experimental
user-provided value
connection.setRequestMethod("GET"); | ||
connection.setDoOutput(true); | ||
connection.setRequestProperty("Authorization", "Basic " + sonarAuth); | ||
|
Check failure
Code scanning / CodeQL
Insecure basic authentication High test
HTTP URL
@darkspirit510 - Is this ready to merge/do you want me to merge it? |
@darkspirit510 no, CodeQL reports an issue. Will fix it this week! |
@davewichers I understand why CodeQL reports those as (technically) insecure, but I won't fix them. It's just a local parser accessing local SonarQube, so those three results can be marked as "won't fix". |
I'm OK with that. If we accept these 3 CodeQL issues, then are you OK with merging this in now? |
No description provided.