Skip to content

SonarQube report as Java class #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

darkspirit510
Copy link
Contributor

No description provided.

(result -> hotspots.addAll(result.hotspots)));

writeStringToFile(
new File("results/" + resultFilename() + ".json"),

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High test

This path depends on a
user-provided value
.
(result -> hotspots.addAll(result.hotspots)));

writeStringToFile(
new File("results/" + resultFilename() + ".json"),

Check failure

Code scanning / CodeQL

File Path Injection Error test Experimental

External control of file name or path due to
user-provided value
.
connection.setRequestMethod("GET");
connection.setDoOutput(true);
connection.setRequestProperty("Authorization", "Basic " + sonarAuth);

Check failure

Code scanning / CodeQL

Insecure basic authentication High test

Insecure basic authentication from a
HTTP URL
.
@davewichers
Copy link
Contributor

@darkspirit510 - Is this ready to merge/do you want me to merge it?

@darkspirit510
Copy link
Contributor Author

@darkspirit510 no, CodeQL reports an issue. Will fix it this week!

@darkspirit510
Copy link
Contributor Author

@davewichers I understand why CodeQL reports those as (technically) insecure, but I won't fix them. It's just a local parser accessing local SonarQube, so those three results can be marked as "won't fix".

@davewichers
Copy link
Contributor

davewichers commented Mar 24, 2025

I'm OK with that. If we accept these 3 CodeQL issues, then are you OK with merging this in now?

@davewichers davewichers merged commit e8af2b1 into OWASP-Benchmark:master Mar 31, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants