Add master password strength checks to PwdManager
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropbox's `zxcvbn` password strength estimator is used to help ensure that the master password used for the password manager is strong. The manager enforces that the master password strength estimate is the maximum possible score of 4. If the password strength is less than 4, functions that set or update the master password return the newly introduced error variant, `WeakPassword`.
OTheDev
added a commit
that referenced
this pull request
Apr 26, 2024
- Introduced `DuplicateId` error variant for improved error handling (#4) - Added master password strength checks to `PwdManager` (#5) - Use transaction in `PwdManager::new()` for atomicity (#6) - Added `found_signature()` method to `PwdManager` (#7) - Enhanced user interactions for master password input (#8)
Merged
OTheDev
added a commit
that referenced
this pull request
Apr 26, 2024
- Introduced `DuplicateId` error variant for improved error handling (#4) - Added master password strength checks to `PwdManager` (#5) - Use transaction in `PwdManager::new()` for atomicity (#6) - Added `found_signature()` method to `PwdManager` (#7) - Enhanced user interactions for master password input (#8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropbox's
zxcvbnpassword strength estimator is used to help ensure that the master password used for the password manager is strong. The manager enforces that the master password strength estimate is the maximum possible score of 4. If the password strength is less than 4, functions that set or update the master password return the newly introduced error variant,WeakPassword.