Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis quote inside quote #170

Open
amkartashov opened this issue Nov 8, 2023 · 2 comments
Open

redis quote inside quote #170

amkartashov opened this issue Nov 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@amkartashov
Copy link
Contributor

https://github.com/OT-CONTAINER-KIT/helm-charts/blob/cfe2734d3f2894fd6c62b4143a5ac01855297e33/charts/redis/templates/redis-standalone.yaml#L18C1-L20

    redisSecret:
      name: "{{ .Values.redisStandalone.redisSecret.secretName | quote }}"
      key: "{{ .Values.redisStandalone.redisSecret.secretKey | quote }}"

rendering with below values

redisStandalone:
  redisSecret:
    secretName: redis-secret
    secretKey: password

will produce:

# Source: redis/templates/redis-standalone.yaml
...
    redisSecret:
      name: ""redis-secret""
      key: ""password""
@amkartashov amkartashov added the bug Something isn't working label Nov 8, 2023
@shubham-cmyk
Copy link
Member

shubham-cmyk commented Nov 8, 2023 •
edited
Loading

Thanks for reporting this.
would you consider opening a PR ?

amkartashov added a commit to amkartashov/OT-CONTAINER-KIT_helm-charts that referenced this issue Nov 8, 2023
@amkartashov
fix for OT-CONTAINER-KIT#170
b9a181d
@amkartashov amkartashov mentioned this issue Nov 8, 2023
Merged
amkartashov added a commit to amkartashov/OT-CONTAINER-KIT_helm-charts that referenced this issue Nov 8, 2023
@amkartashov
fix for OT-CONTAINER-KIT#170
0179d6c 
Signed-off-by: Andrei Kartashov <a@ioot.xyz>
@amkartashov
Copy link
Contributor Author

Thanks for reporting this. would you consider opening a PR ?

done

shubham-cmyk added a commit that referenced this issue Nov 8, 2023
@amkartashov @shubham-cmyk
remove unnecessary quotes (#171)
c54e65c 
* fix for #170

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-cluster.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-replication.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-sentinel.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* version  bump

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Andrei Kartashov <a@ioot.xyz>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this issue Nov 28, 2023
@amkartashov @shubham-cmyk @sho34215
remove unnecessary quotes (OT-CONTAINER-KIT#171)
2166465 
* fix for OT-CONTAINER-KIT#170

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-cluster.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-replication.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-sentinel.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* version  bump

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Andrei Kartashov <a@ioot.xyz>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this issue Nov 28, 2023
@amkartashov @shubham-cmyk @sho34215
remove unnecessary quotes (OT-CONTAINER-KIT#171)
ecb7724 
* fix for OT-CONTAINER-KIT#170

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-cluster.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-replication.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-sentinel.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* version  bump

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Andrei Kartashov <a@ioot.xyz>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this issue Nov 28, 2023
@amkartashov @shubham-cmyk @sho34215
remove unnecessary quotes (OT-CONTAINER-KIT#171)
369956c 
* fix for OT-CONTAINER-KIT#170

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-cluster.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-replication.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-sentinel.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* version  bump

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Andrei Kartashov <a@ioot.xyz>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this issue Nov 28, 2023
@amkartashov @shubham-cmyk @sho34215
remove unnecessary quotes (OT-CONTAINER-KIT#171)
31752a5 
* fix for OT-CONTAINER-KIT#170

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-cluster.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-replication.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* Update redis-sentinel.yaml

Signed-off-by: Andrei Kartashov <a@ioot.xyz>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* version  bump

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix CI

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Andrei Kartashov <a@ioot.xyz>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amkartashov @shubham-cmyk