Repository navigation
Conversation
Upstream gating is denylist-only, so any installation could build. Self-hosts need the inverse. Unset keeps allow-all. Logins are compared case-insensitively: what an operator types is not necessarily the casing GitHub sends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertIsAllowedToBuildconsults a denylist only, so on a self-hosted instance anyone who installs the GitHub App can spend your builders. This adds the inverse.GARNIX_ALLOWED_OWNERSis a comma-separated list of owners permitted to build. Unset, empty, or separators-only keeps the current allow-all, so existing deployments are unaffected.The decision is two pure functions rather than inline logic in the monad, so it is testable without a database. Both sides of the comparison go through
normalizeGhLogin: GitHub logins are case-insensitive butGhLogincompares as plainText, and what an operator types into a deployment is not necessarily the casing the webhook carries. Without that,KraDalbyin the env var locks outkradalbywith no error anywhere.