feat: implemented a reset feature when a user has selected a province #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chaaals is attempting to deploy a commit to the OSSPH Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice, this is exactly what I was looking for. Thank you! |
jofftiquez
approved these changes
Apr 27, 2023
|
@denzdelvillar @warengonzaga do you mind reviewing this? Thanks. |
warengonzaga
approved these changes
Apr 27, 2023
I'm good with the current message in the success snackbar. Do you have something else in mind? |
No, I mean glad to have the message after reset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
Description
This PR adds a reset feature to the web app.
Implementation Details
I utilized context api in this change so that we can make
provinceLevelsa global state. I implemented thereset buttonbeside thesave imagebutton. I also implemented a constraint that users will only be able to reset when at least 1 province is selected. I also added a toast for better UX :))Demo
2023-04-27.15-00-15.mp4