-
Notifications
You must be signed in to change notification settings - Fork 8
added ProgressBar
and Toast
components 9d
#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
frui/src/element/Toast.tsx
Outdated
}; | ||
|
||
const typeStyles: Record<NonNullable<ToastProps['type']>, CSSProperties> = { | ||
info: { backgroundColor: '#e7f5ff', color: '#0c5460', borderColor: '#b8daff' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize Hex
frui/styles/progressbar.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alphabetize style properties.
frui/styles/toast.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alphabetize style properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Chris, just finished pushing all the requested changes for this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split into 2 PRs
@@ -0,0 +1,24 @@ | |||
.frui-progress { | |||
background-color: #e0e0e0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capital hex
transition: width 0.2s ease-in-out; | ||
} | ||
|
||
/*example*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove.
.frui-toast-info { | ||
background-color: #e7f5ff; | ||
border-color: #b8daff; | ||
color: #0c5460; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capital hex
What is this PR for?
I verify that...
npm run test
with no errors