Revise config.cmake generation #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- install(TARGETS) does not need explicitly setting variables - Genex $<INSTALL_PREFIX> is more reliable than hard-coded CMAKE_INSTALL_PREFIX Signed-off-by: Cristian Le <git@lecris.dev>
|
libgeotiff's CMake configuration is very old. I think this activity is good alignment with modern CMake, but we need to be careful to let the packagers who might have been scaffolding around our crufty configuration catch up on the next release. |
|
I come from Fedora packaging 1 and this is part of the removal of questionable default options in Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake already provides built-in support for making sure the package is relocatable. This PR contains:
CMakePackageConfigHelpershelpersINSTALL_CMAKE_DIRfromsharetoCMAKE_INSTALL_LIBDIR.shareis only supposed to be used for architecture independent packages. Changed it for Windows as well because it is generally a common practice to use GNUInstallDirs compatible paths for Windows as well (see vcpkg), but feel free to alter it if you have different needs there.@PROJECT_NAME@_*_DIRScalculated fromPATH_VARS.CMAKE_INSTALL_*vars is not relative toCMAKE_INSTALL_PREFIX, but the previous approach is also prone to breakingDEPRECATEDcomponent and emit a warning if these are usedINSTALL_NAME_DIRto use genex to be more relocatable-config.cmake->Config.cmake,-depends.cmake->Targets.cmake. Please see about changingEXPORT dependsas well