Update ECW Dynamic driver to build with ECW SDK version 6.0 or higher #11593
Conversation
Update ECW Dynamic driver to work with ECW SDK version 6.0 or higher
psharma-gdal
changed the title
frmts/ecw/ecwdataset.cpp
Outdated
| @@ -2262,7 +2262,7 @@ CPLErr ECWDataset::IRasterIO(GDALRWFlag eRWFlag, int nXOff, int nYOff, | |||
| { | |||
| // This is tricky, because it expects the rest of the image | |||
| // with this buffer width to be read. The preferred way to | |||
| // achieve this behavior would be to call AdviseRead before | |||
| // achieve this behaviour would be to call AdviseRead before | |||
| // call IRasterIO. The logic could be improved to detect | |||
There was a problem hiding this comment.
I believe that we have chosen to use American English.
There was a problem hiding this comment.
I have reverted back the code change to use American English.
| pszOpt = CPLGetConfigOption("ECW_RESILIENT_DECODING", nullptr); | ||
| if (pszOpt) | ||
| NCSecwSetConfig(NCSCFG_RESILIENT_DECODING, | ||
| (BOOLEAN)CPLTestBool(pszOpt)); |
There was a problem hiding this comment.
Is everything still good if 60<ECWSDK_VERSION>=40?
There was a problem hiding this comment.
Yes. And the new code changes are going to support ECWSDK_VERSION>=60 as well.
@psharma-gdal Can you provide a URL where to download this SDK ? |
@rouault - ECW SDK version 6.0 or higher isn't publicly available. The ECW SDK version 6.1 should be available in couple of months. We will let you know once its available. |
|
@psharma-gdal I've notice odd formatting in your PR. Can you setup pre-commit as documented in https://gdal.org/en/stable/development/dev_practices.html#commit-hooks and force run it onto your files |
Formatting changes for ecw dynamic driver files using pre-commit hook
I am in process of getting the autotests running. However, are these autotests only in Python? Is there no way to run these as part of the C++ build? |
yes. Documentation related to Python autotests is at https://gdal.org/en/latest/development/testing.html |
Adding the change to allow writing VERSION tag in JP2 files
Update the ECW Python based tests to support ECW >=6.0 as well
Formatting changes suggested by pre-commit hook
I have edited the ecw.py to run against ECW SDK >= 6.0 and they run ok. |
|
The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 28 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Update ECW Dynamic driver to build with ECW SDK version 6.0 or higher