OGRFeature: SetXXX() methods: more informative warning messages reporting field name and value for out-of-range values #10945
Conversation
rouault
force-pushed
the
fix_10915
branch
2 times, most recently
from
ee44817
to
e0ba014
Compare
…ting field name and value for out-of-range values Fixes OSGeo#10915
|
Hi! great PR! I think would be nice, for the integer cases (or similar ones), add if they are signed/unsigned ones in the message. Thx! |
the actual value that fails to be set is put in the error message |
|
Hi! yes, I means not the value's symbol (if is signed or not), the objective field type, in C++ a Integer 64 is Signed by default, while in other langs is not always the case, so I think would be good say explicitly if the field that is being used if is a signed or unsigned one. This is also because this warning is for the final user, who does not needs to know in which lang this was done, helps for a clear description. |
I let it to others to further tweak that if that's needed. I believe this PR as it is sufficient. Signedness of OFTInteger/OFTInteger64 explicited in 46ad0f1 |
Fixes #10915