Skip to content

Update Select-OSDCloudFileWim.ps1 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HeeringsNET
Copy link

Added an 'ElseIf' so the image gets automatically selected if there is only one file found. This is useful when running OSDCloud with the 'ZTI' parameter and without user interaction.

Added an 'ElseIf' so the image gets automatically selected if there is only one file found.
Forgot '.Count' in the 'ElseIf' conditional test.
@OSDeploy OSDeploy self-assigned this Mar 18, 2025
@OSDeploy OSDeploy added good first issue Good for newcomers wontfix This will not be worked on labels Mar 18, 2025
@OSDeploy
Copy link
Owner

I appreciate you contributing and adding this, but there are a few issues.
First, this functionality is part of OSDCloud v1, which development has stopped so that we can focus on the next release of OSDCloud, which will be previewed later this month.
Secondly, I won't be able to test this PR until after I return from vacation, so April will be the earliest.
Finally, I don't consider this is a high priority as it does not impact many people, so this may sit pending review.

Sadly, this PR is in a bad place. I'm not saying this won't be reviewed, but I want to set the expectation. This configuration has been in place for years without needing to be addressed until now, so that makes me lean towards holding off on this chance.

I'll add that this is OSDCloud v1, which will probably not function after the end of the year, meaning you'll need to be using the newest version of OSDCloud. As of this time, there have not been plans to support this method of deployment. You guys that let this run automated don't give much feedback, and its hard to measure with you being so silent, so to me as the dev, it looks like noone is using this deployment method,

I'm marking this as won't fix for now, but will leave open so I can wait for your comments.

David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants