Fix handling of no wells in WellStateFullyImplicitBlackoil.hpp #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In that case we cannot call numPhases() on the wells as it produces a floating point exception. As we do not use that information in this case anyway, we simply use -1 instead to prevent the call.
| const int np = this->numPhases(); | ||
| // If there are now wells numPhases throws a floating point | ||
| // exception. | ||
| const int np = nw ? this->numPhases() : -1; |
There was a problem hiding this comment.
A more elegant fix: move the np variable inside the for-loop, since it is only used there. (Won't require, tell me if you want to do that or keep this as currently proposed.)
There was a problem hiding this comment.
I would prefer to leave at as is. Only one if branch and one division
in this case.
There was a problem hiding this comment.
Ok.
(But I don't see why we'd need an if, that was the point of putting it in the loop where it would unconditionally be ok?)
akva2
added a commit
to akva2/opm-simulators
that referenced
this pull request
Jan 13, 2023
return proper communicator for DUNE2.6 (<2.7)
akva2
added a commit
to akva2/opm-simulators
that referenced
this pull request
Sep 2, 2024
return proper communicator for DUNE2.6 (<2.7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In that case we cannot call numPhases() on the wells as it produces
a floating point exception. As we do not use that information in this case
anyway, we simply use -1 instead to prevent the call.
Closes #731