ECL output cleanup and tasklets #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this with downstreams opm-simulators=1434 please |
this should be done by the vanguard, not by the problem!
this is based on the asynchronous ECL output code, but it has been substantially cleaned up: - it does not do no polling anymore - it supports barriers - the terminology has been improved and generalized - the code is now properly documented so far, only a single worker thread is used, but changing this is trivial from the tasklet runner's point of view. (The tasklets themselfs are a different story.)
this commit does not do any logic changes, just identation, variable names, etc.
|
jenkins build this with downstreams opm-simulators=1434 please |
1 similar comment
|
jenkins build this with downstreams opm-simulators=1434 please |
|
ok, jenkins is finally happy. if there are no objections, I'll merge this tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR does a smallish cleanup of the ECL output code and introduces "tasklets", a mechanism to run jobs asynchronously. the tasklet code is based on the asynchronous ECL output code, but it has been substantially cleaned up:
so far, only a single worker thread is used, but changing this is trivial from the tasklet runner's point of view. (The tasklets themselfs are a different story.)
this PR needs a small mop-up patch in opm-simulators.