-
Notifications
You must be signed in to change notification settings - Fork 116
Set C++ standard to 20 for dune-common >= 2.11 #4776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This change ensures that the C++ standard is set to 20 when using dune-common version 2.11 or greater. The reasoning is that (the soon to be released) dune 2.11 will require mandatory C++20.
jenkins build this please |
OK, this is a bit strange. There should be exactly 0 changes when using DUNE 2.10, yet we have a failing test (mpi.compareECLFiles_flow+UDQ-01 with
Could be a race condition because between merges in opm-tests and another module, but there is nothing in opm-tests. |
jenkins build this please |
I just double checked that C++20 is not being set when DUNE is lower than 2.11 (CMake conditionals are some times picky). So I don't think it comes from this PR either. |
For what it's worth, |
Thanks @bska. I'll check the two jenkins runs. The second one succeeded 😬 Admittedly, I am a bit worried about this, but also quite sure that it cannot be from this PR. |
This change ensures that the C++ standard is set to 20 when using dune-common version 2.11 or greater. The reasoning is that (the soon to be released) dune 2.11 will require mandatory C++20.
Note that this requires OPM/opm-simulators#6518 for smooth transition into C++20 later on.
Close #4775