Refactor caf::PdmObject collections #13356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriben
force-pushed
the
collection-prototype
branch
4 times, most recently
from
d8d3a7e to
4b61ff8
Compare
kriben
changed the title
magnesj
requested changes
Dec 22, 2025
Member
magnesj
left a comment
magnesj
left a comment
There was a problem hiding this comment.
New valve template is not visible in the Project Tree. When "Delete valve template" is executed, the Project Tree is updated correctly.
kriben
force-pushed
the
collection-prototype
branch
from
4b61ff8 to
5167301
Compare
Collaborator
Author
Fixed in amended code. Was missing a updateConnectedEditors on the collection (in addition to the m_items->->updateConnectedEditors). |
magnesj
requested changes
Jan 5, 2026
Member
magnesj
left a comment
magnesj
left a comment
There was a problem hiding this comment.
Rename two functions to indicate delete of object(s)
kriben
force-pushed
the
collection-prototype
branch
from
5167301 to
cbf6c59
Compare
magnesj
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.