Skip to content

Fix non enumerable generic type info construction#3597

Merged
marcschier merged 3 commits intoOPCFoundation:masterfrom
JMolenkamp:fix-non-enumerable-generic-type-info-construction
Mar 9, 2026
Merged

Fix non enumerable generic type info construction#3597
marcschier merged 3 commits intoOPCFoundation:masterfrom
JMolenkamp:fix-non-enumerable-generic-type-info-construction

Conversation

@JMolenkamp
Copy link
Contributor

@JMolenkamp JMolenkamp commented Mar 7, 2026

Proposed changes

Require a single argument generic type (e.g. List<int>) to at least implement IEnumerable for Type.Construct(Type type) to represent it as an array.

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2026

CLA assistant check
All committers have signed the CLA.

@JMolenkamp
Copy link
Contributor Author

JMolenkamp commented Mar 7, 2026

Any tips for running the tests locally, without it taking forever?
I simply did a 'Run all' in the Visual Studio Test Explorer, but aborted after it ran about 400 of 127.000 tests in several minutes...

@JMolenkamp JMolenkamp marked this pull request as ready for review March 7, 2026 20:19
@JMolenkamp JMolenkamp force-pushed the fix-non-enumerable-generic-type-info-construction branch from 5933ce5 to ae84086 Compare March 7, 2026 21:42
@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.14%. Comparing base (d25caff) to head (ca7070e).
⚠️ Report is 134 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3597       +/-   ##
===========================================
+ Coverage   51.86%   66.14%   +14.27%     
===========================================
  Files         370      459       +89     
  Lines       78618    97717    +19099     
  Branches    13650    16376     +2726     
===========================================
+ Hits        40779    64639    +23860     
+ Misses      33705    28009     -5696     
- Partials     4134     5069      +935     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett
Copy link
Contributor

romanett commented Mar 8, 2026

@JMolenkamp you can select Just to Run one Framework Version. Also Client Tests Take 10-20 mins all Others are faster

@romanett
Copy link
Contributor

romanett commented Mar 9, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@romanett
Copy link
Contributor

romanett commented Mar 9, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcschier marcschier merged commit 25a4882 into OPCFoundation:master Mar 9, 2026
116 of 117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeInfo.Construct represents all single argument generic types as arrays

4 participants