Skip to content

Respect configured RSA minimum certificate key size when creating RSA app certificates#3513

Merged
mrsuciu merged 1 commit into
OPCFoundation:masterfrom
mrsuciu:Issue#3512
Feb 2, 2026
Merged

Respect configured RSA minimum certificate key size when creating RSA app certificates#3513
mrsuciu merged 1 commit into
OPCFoundation:masterfrom
mrsuciu:Issue#3512

Conversation

@mrsuciu
Copy link
Copy Markdown
Contributor

@mrsuciu mrsuciu commented Jan 30, 2026

Proposed changes

If a minimum RSA certificate key size is specified in the application configuration and no existing RSA application certificate is present the created application RSA certificate will have a key size equal to the specified MinimumCertificateKeySize configuration parameter.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.12%. Comparing base (d25caff) to head (5517316).
⚠️ Report is 103 commits behind head on master.

Files with missing lines Patch % Lines
...raries/Opc.Ua.Configuration/ApplicationInstance.cs 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3513      +/-   ##
==========================================
+ Coverage   51.86%   60.12%   +8.25%     
==========================================
  Files         370      378       +8     
  Lines       78618    78930     +312     
  Branches    13650    13736      +86     
==========================================
+ Hits        40779    47456    +6677     
+ Misses      33705    27104    -6601     
- Partials     4134     4370     +236     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrsuciu mrsuciu requested a review from romanett January 30, 2026 18:05
Copy link
Copy Markdown
Contributor

@romanett romanett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SecurityConfiguration certificate key size is not used by ApplicationInstance to generate a new certificate

2 participants