Fix thread pool exhaustion with many MQTT writer groups #3395
+97
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Thread pool starvation occurred when publishing to ~50 MQTT topics. Each
WriterGroupspawned anIntervalRunnerthat blocked thread pool threads on a lock inMqttPubSubConnection.PublishNetworkMessage, then blocked again onGetAwaiter().GetResult().Changes:
PublishNetworkMessagetoPublishNetworkMessageAsync(asyncTask<bool>) across all PubSub connections following .NET async naming conventionsIntervalRunnerto acceptFunc<Task>instead ofAction, eliminating thread pool blockingGetAwaiter().GetResult()patterns in publish pathsTaskper .NET conventionsKey files:
IUaPubSubConnection.cs- Interface signature change toPublishNetworkMessageAsyncMqttPubSubConnection.cs- Removed blocking on async MQTT publishUdpPubSubConnection.cs- Async signature for consistencyIntervalRunner.cs- Support async actionsUaPublisher.cs,MqttMetadataPublisher.cs,UdpDiscoverySubscriber.cs- Async publish methodsUdpDiscoveryPublisher.cs- Updated to callPublishNetworkMessageAsyncRelated Issues
Addresses thread pool exhaustion reported in issue with ~50 writer groups.
Types of changes
Checklist
Further comments
The async conversion follows .NET naming conventions with "Async" suffix on all methods returning
Task. Callers can await the Task or continue calling synchronously. UDP transport also converted to async for consistency, though it doesn't suffer from the same blocking issue.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.