-
Notifications
You must be signed in to change notification settings - Fork 1k
Make Network Socket in UdpPubSubConnection reachable #3385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@copilot Please continue work |
…tion Co-authored-by: romanett <7413710+romanett@users.noreply.github.com>
Co-authored-by: romanett <7413710+romanett@users.noreply.github.com>
…ng wrapper Co-authored-by: romanett <7413710+romanett@users.noreply.github.com>
…ification Co-authored-by: romanett <7413710+romanett@users.noreply.github.com>
Co-authored-by: romanett <7413710+romanett@users.noreply.github.com>
I've completed the implementation. The UdpPubSubConnection now exposes PublisherUdpClients and SubscriberUdpClients properties that return read-only lists of UDP clients, allowing users to configure socket settings like ReceiveBuffer size. The changes include comprehensive tests and follow the coding standards. See commit 506a461. |
Proposed changes
This PR exposes the UDP client sockets in
UdpPubSubConnectionto allow users to configure socket settings such as ReceiveBuffer size. Users can now access the underlying UDP clients through two new public read-only properties.Implementation Details
PublisherUdpClientsproperty: Returns a read-only list of active UDP clients used for publishingSubscriberUdpClientsproperty: Returns a read-only list of active UDP clients used for subscribingIReadOnlyList<UdpClient>usingAsReadOnly()to ensure true immutabilityUsage Example
Related Issues
Types of changes
What types of changes does your code introduce?
Checklist
Further comments
The implementation follows the existing patterns in the codebase and provides safe, read-only access to the UDP clients while maintaining thread safety. The returned collections cannot be modified externally, but the underlying UdpClient objects and their Socket properties can be accessed for configuration purposes.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.