Fix BaseEventState.MemberwiseClone() to pass Parent to Activator.CreateInstance

[Copilot]

Proposed changes

BaseEventState.MemberwiseClone() throws an exception because it calls Activator.CreateInstance(GetType()) without passing the required parent argument. All BaseEventState inheritors (e.g., NonExclusiveLimitAlarmState, AlarmState) only have a constructor requiring NodeState parent.

Fix: Pass Parent to Activator.CreateInstance(), matching the correct pattern in BaseObjectState.MemberwiseClone():

// Before (broken)
var clone = (BaseEventState)Activator.CreateInstance(GetType());

// After (fixed)
var clone = (BaseEventState)Activator.CreateInstance(GetType(), Parent);

Added unit tests for BaseEventState and derived type cloning.

Related Issues

• Fixes BaseEventState.MemberwiseClone() has incorrect implementations #3346

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds functionality)
• Test enhancement (non-breaking change to increase test coverage)
• Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc.
• I have signed the CLA.
• I ran tests locally with my changes, all passed.
• I fixed all failing tests in the CI pipelines.
• I fixed all introduced issues with CodeQL and LGTM.
• I have added tests that prove my fix is effective or that my feature works and increased code coverage.
• I have added necessary documentation (if appropriate).
• Any dependent changes have been merged and published in downstream modules.

Further comments

N/A

Original prompt

---

This section details on the original issue you should resolve

<issue_title>BaseEventState.MemberwiseClone() has incorrect implementations</issue_title>
<issue_description>### Type of issue

• Bug
• Enhancement
• Compliance
• Question
• Help wanted

Current Behavior

BaseEventState.MemberviseClone() throws exception.

Expected Behavior

call of MemberviseClone() on BaseEventState inheritor instances should creates deep clones.

Steps To Reproduce

Try to call MemberviseClone() on any AlarmState inheritor instance.

Environment

- OS: any
- Environment: any
- Runtime: any
- Nuget Version: 1.5.376.244
- Component: Opc.Ua.Core/Stack/State/

Anything else?

BaseEventState and inheritors do not have parameterless constructor but have a constructor with argument "parent". MemberwiseClone() for them doesn't take into account required argument "parent" of their constructor.

Sample for NonExclusiveLimitAlarmState and BaseEventState:
the only consructors:
public NonExclusiveLimitAlarmState(NodeState parent) : base(parent) { }
public BaseEventState(NodeState parent) : base(parent) { }

MemberwiseClone() have incorrect implementations defined in BaseEventState:
public new object MemberwiseClone() { BaseEventState clone = (BaseEventState)Activator.CreateInstance(this.GetType()); return CloneChildren(clone); }

In the same time more correct implementation should be like in BaseObjectState:
public new object MemberwiseClone() { BaseObjectState clone = (BaseObjectState)Activator.CreateInstance(this.GetType(), this.Parent); return CloneChildren(clone); }

I do not understand why special (incorrect) implementation of MemberwiseClone() is needed for BaseEventState and why base implementation from BaseObjectState is not used instead...
</issue_description>

<agent_instructions>Please fix this issue</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes BaseEventState.MemberwiseClone() has incorrect implementations #3346

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}