Fix: Allow calling methods with only output parameters#3354
Merged
Conversation
|
|
…only output parameters Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com>
…ection expressions Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix call method issue with only output parameter
Fix: Allow calling methods with only output parameters
Nov 22, 2025
marcschier
approved these changes
Nov 27, 2025
Contributor
|
@marcschier I am not against the fix & the test, but isnt this already fixed by a past decoder update? |
romanett
approved these changes
Nov 27, 2025
marcschier
approved these changes
Dec 1, 2025
This was referenced Jan 29, 2026
Open
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes validation error when calling OPC UA methods that have only output parameters (no input parameters). The
BinaryDecoder.ReadVariantArray()returnsnullfor empty arrays (array length = -1 on wire), causing validation to incorrectly reject these valid method calls.Changes:
MasterNodeManager.ValidateCallRequestItem()to initializeInputArgumentsto empty collection when nullRelated Issues
Types of changes
Checklist
Further comments
The fix is minimal and surgical - only modifying validation to handle the null case that occurs during deserialization. All existing tests pass (156/156 Server tests), plus 3 new tests specifically validate the fix.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.