Add API back as Obsolete for samples to compile (almost) unchanged. #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3234 +/- ##
==========================================
- Coverage 57.59% 57.52% -0.08%
==========================================
Files 361 361
Lines 79152 79163 +11
Branches 13814 13821 +7
==========================================
- Hits 45587 45537 -50
- Misses 29336 29397 +61
Partials 4229 4229 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds obsolete methods and constructors to ensure .NET samples compile with minimal changes when upgrading to a version that requires telemetry context parameters. The changes preserve backward compatibility by providing deprecated overloads that internally call the new telemetry-enabled constructors with fallback values.
Key changes include:
- Adding obsolete constructors and methods that omit ITelemetryContext parameters
- Updating existing code to use the new constructor signatures
- Renaming
LogInformationtoLogInfofor consistency
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/Opc.Ua.Gds.Tests/ServerConfigurationPushTestClient.cs | Updated constructor call to remove telemetry parameter |
| Tests/Opc.Ua.Client.Tests/TraceableRequestHeaderClientSessionFactory.cs | Removed telemetry parameters from session creation |
| Tests/Opc.Ua.Client.Tests/TraceableRequestHeaderClientSession.cs | Updated constructors to remove telemetry parameters |
| Tests/Opc.Ua.Client.Tests/TestableSession.cs | Removed telemetry parameter from constructor call |
| Tests/Opc.Ua.Client.Tests/ReverseConnectTest.cs | Updated DiscoveryClient.Create call to remove telemetry |
| Tests/Opc.Ua.Client.Tests/ClientTest.cs | Updated base constructor call to remove telemetry |
| Stack/Opc.Ua.Core/Types/Utils/UtilsObsolete.cs | Renamed LogInformation methods to LogInfo and updated references |
| Stack/Opc.Ua.Core/Types/Utils/ServiceMessageContext.cs | Added obsolete parameterless constructor |
| Stack/Opc.Ua.Core/Types/Utils/DataGenerator.cs | Added obsolete constructor without telemetry parameter |
| Stack/Opc.Ua.Core/Types/BuiltIn/DiagnosticInfo.cs | Added obsolete constructors without logger parameter |
| Stack/Opc.Ua.Core/Stack/Nodes/IFilterTarget.cs | Added obsolete FilterContext constructors |
| Stack/Opc.Ua.Core/Stack/Configuration/SecurityConfigurationManager.cs | Added obsolete parameterless constructor |
| Stack/Opc.Ua.Core/Stack/Configuration/ConfiguredEndpoints.cs | Added obsolete UpdateFromServerAsync overloads |
| Stack/Opc.Ua.Core/Stack/Client/UserIdentity.cs | Refactored constructors and added obsolete X509IdentityToken constructor |
| Stack/Opc.Ua.Core/Stack/Client/UaChannelBase.cs | Removed telemetry parameters from CreateUaBinaryChannel methods |
| Stack/Opc.Ua.Core/Stack/Client/SessionChannel.cs | Removed telemetry parameters from Create methods |
| Stack/Opc.Ua.Core/Stack/Client/RegistrationClient.cs | Updated Create method call to remove telemetry parameter |
| Stack/Opc.Ua.Core/Stack/Client/DiscoveryClient.cs | Added obsolete Create method overloads and updated implementations |
| Stack/Opc.Ua.Core/Security/Certificates/CertificateValidator.cs | Added obsolete parameterless constructor |
| Stack/Opc.Ua.Core/Security/Certificates/CertificateIdentifier.cs | Added obsolete OpenStore method without telemetry |
| Stack/Opc.Ua.Core/Security/Certificates/CertificateFactory.cs | Added obsolete Create and Load methods without telemetry |
| Libraries/Opc.Ua.Server/ServerUtils.cs | Added obsolete CreateDiagnosticInfo method |
| Libraries/Opc.Ua.Server/Aggregates/Aggregators.cs | Added obsolete CreateStandardCalculator method |
| Libraries/Opc.Ua.Server/Aggregates/AggregateCalculator.cs | Added obsolete constructor |
| Libraries/Opc.Ua.Gds.Server.Common/CertificateGroup.cs | Added obsolete parameterless constructor |
| Libraries/Opc.Ua.Gds.Client.Common/ServerPushConfigurationClient.cs | Updated constructor and removed telemetry field |
| Libraries/Opc.Ua.Gds.Client.Common/LocalDiscoveryServerClient.cs | Updated constructor to remove telemetry parameter |
| Libraries/Opc.Ua.Gds.Client.Common/GlobalDiscoveryServerClient.cs | Updated constructor and removed telemetry field |
| Libraries/Opc.Ua.Client/Subscription/Subscription.cs | Added obsolete parameterless constructor |
| Libraries/Opc.Ua.Client/Session/SessionClientBatched.cs | Updated constructor to remove telemetry parameter |
| Libraries/Opc.Ua.Client/Session/Session.cs | Updated constructors and methods to remove telemetry parameters |
| Libraries/Opc.Ua.Client/Session/Factory/DefaultSessionFactory.cs | Updated method calls to remove telemetry parameters |
| Libraries/Opc.Ua.Client/CoreClientUtils.cs | Added obsolete SelectEndpointAsync overloads |
| Libraries/Opc.Ua.Client/Browser.cs | Added constructor overload that uses session's telemetry |
| Libraries/Opc.Ua.Client.ComplexTypes/ComplexTypeSystem.cs | Updated constructors to use session's telemetry context |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
suciumr
approved these changes
Oct 3, 2025
mrsuciu
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added obsoleted methods to ensure .net samples compile (almost) unchanged.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...