Skip to content

Conversation

@romanett
Copy link
Contributor

@romanett romanett commented Sep 7, 2025

Proposed changes

Extend MasterNodeManager with support for

  • ReadAsync
  • WriteAsync
  • HistoryReadAsync
  • HistoryWriteAsync
  • TranslateBrowsePathAsync,
  • ConditionRefreshAsync
  • BrowseAsync
  • BrowseNextAsync

A base implementation in the NodeManager layer will follow at a later point in time with a CustomNodeManager3, when the IAsyncNodeManager Interface is complete.

Related Issues

  • Fixes #

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@codecov
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

❌ Patch coverage is 64.21471% with 180 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.39%. Comparing base (4cf9fb8) to head (7232230).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ies/Opc.Ua.Server/NodeManager/MasterNodeManager.cs 62.45% 96 Missing and 11 partials ⚠️
Libraries/Opc.Ua.Server/Server/StandardServer.cs 76.96% 38 Missing and 3 partials ⚠️
...c.Ua.Server/NodeManager/AsyncNodeManagerAdapter.cs 20.00% 28 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3188      +/-   ##
==========================================
- Coverage   57.61%   57.39%   -0.22%     
==========================================
  Files         355      355              
  Lines       78087    78535     +448     
  Branches    13822    13854      +32     
==========================================
+ Hits        44990    45076      +86     
- Misses      28860    29213     +353     
- Partials     4237     4246       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett romanett requested a review from Copilot September 7, 2025 09:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the MasterNodeManager with asynchronous support for several key OPC UA operations, introducing async methods for ReadAsync, WriteAsync, HistoryReadAsync, HistoryWriteAsync, TranslateBrowsePathAsync, and ConditionRefreshAsync. This modernizes the codebase by adding async capabilities while maintaining backward compatibility.

Key changes:

  • Adds new async-capable interfaces for individual operations
  • Extends MasterNodeManager to support both sync and async execution paths
  • Implements proper async/await patterns with cancellation token support
  • Creates an adapter pattern to allow existing synchronous node managers to work with the async infrastructure

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Opc.Ua.Core.csproj Removes exclusions for async operations to enable new async methods
StandardServer.cs Adds async method implementations for TranslateBrowsePathsToNodeIds, Read, HistoryRead, Write, and HistoryUpdate services
MasterNodeManager.cs Implements comprehensive async support with internal async methods and adapter patterns for backward compatibility
INodeManager.cs Defines new async-capable interfaces for individual operations and marks the combined interface as experimental
AsyncNodeManagerAdapter.cs Provides adapter implementation to make synchronous node managers compatible with async interfaces
.editorconfig Suppresses experimental API warnings for the new async interfaces

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@romanett romanett added this to the 1.5.378 Async Server Update 2 milestone Sep 7, 2025
@romanett romanett marked this pull request as ready for review September 8, 2025 05:35
@marcschier marcschier merged commit 9ba17b2 into OPCFoundation:master Sep 11, 2025
76 of 77 checks passed
@romanett romanett deleted the feat/moreAsyncServer branch September 13, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants