-
Notifications
You must be signed in to change notification settings - Fork 1k
[Client] Set default timout hint based on OperationTimeout of the TransportChannel #3178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client] Set default timout hint based on OperationTimeout of the TransportChannel #3178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a default timeout hint mechanism to the ClientBase class by setting the TimeoutHint in request headers based on the OperationTimeout of the transport channel when no explicit timeout is provided.
- Automatically sets
TimeoutHintto theOperationTimeoutvalue when it's not explicitly specified (value is 0) - Enables servers to cancel long-running requests after the timeout period expires
- Improves request management by providing default timeout behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3178 +/- ##
=======================================
Coverage 57.65% 57.66%
=======================================
Files 365 365
Lines 79412 79419 +7
Branches 13862 13865 +3
=======================================
+ Hits 45788 45798 +10
- Misses 29370 29373 +3
+ Partials 4254 4248 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Better Introduce a separate Property to allow to configure the "DefaultServiceCallTimeoutHint" |
Proposed changes
This PR make the ClientBase class set a default Operation Timeout that allows the server to cancel longrunning requests after the Timeout expired.
Types of changes
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...