Skip to content

Conversation

@marcschier
Copy link
Collaborator

@marcschier marcschier commented Aug 24, 2025

… manual reset event (again)

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

❌ Patch coverage is 58.97436% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.97%. Comparing base (a86077a) to head (579d2dc).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...aries/Opc.Ua.Client/Utils/AsyncManualResetEvent.cs 0.00% 28 Missing ⚠️
...braries/Opc.Ua.Client/Utils/AsyncAutoResetEvent.cs 92.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3175      +/-   ##
==========================================
+ Coverage   57.92%   57.97%   +0.05%     
==========================================
  Files         351      353       +2     
  Lines       80471    80549      +78     
  Branches    14028    14037       +9     
==========================================
+ Hits        46611    46699      +88     
+ Misses      29561    29554       -7     
+ Partials     4299     4296       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcschier marcschier merged commit b6b63c9 into master Aug 25, 2025
120 checks passed
@romanett romanett deleted the async branch October 27, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants