Skip to content

Conversation

@romanett
Copy link
Contributor

@romanett romanett commented Aug 21, 2025

Proposed changes

  • Remove net 462 CI
  • Add TestContext Logging support for GDS Tests
  • Fix Tests for netstandard

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.49%. Comparing base (a86077a) to head (1f7b1e7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3170      +/-   ##
==========================================
- Coverage   57.92%   57.49%   -0.43%     
==========================================
  Files         351      353       +2     
  Lines       80471    80549      +78     
  Branches    14028    14037       +9     
==========================================
- Hits        46611    46312     -299     
- Misses      29561    29955     +394     
+ Partials     4299     4282      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett romanett changed the title Enable Test Debug Logging for Server Tests & GDS Tests [Tests] Remove net 462 CI / Add TestContext Logging support for GDS Tests / Fix Tests for netstandard Aug 25, 2025
@romanett romanett marked this pull request as ready for review August 25, 2025 04:50
@romanett romanett requested a review from Copilot August 25, 2025 04:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes .NET Framework 4.6.2 CI pipeline support and enhances test infrastructure by adding TestContext logging support for GDS tests and fixing netstandard compatibility issues.

  • Removes the .NET 4.6.2 CI stage from azure-pipelines.yml
  • Adds TestContext logging integration to GDS test infrastructure
  • Updates conditional compilation directives from NET7_0_OR_GREATER to NET8_0_OR_GREATER for netstandard compatibility

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
azure-pipelines.yml Removes .NET 4.6.2 CI test stage
Tests/Opc.Ua.Server.Tests/ReferenceServerTest.cs Disables sampling groups in reference node manager
Tests/Opc.Ua.Gds.Tests/PushTest.cs Adds TestContext.Out logging support to GDS test setup
Tests/Opc.Ua.Gds.Tests/GlobalDiscoveryTestServer.cs Implements TestContext logging infrastructure with configurable log levels
Tests/Opc.Ua.Gds.Tests/Common.cs Updates conditional compilation and adds TestContext writer parameter
Tests/Opc.Ua.Gds.Tests/ClientTest.cs Integrates TestContext logging in client tests
Tests/Opc.Ua.Core.Tests/Types/Encoders/XmlEncoderTests.cs Updates conditional compilation directive
Tests/Opc.Ua.Core.Tests/Types/Encoders/EncoderSpanExtensions.cs Adds new extension methods for netstandard compatibility
Tests/Opc.Ua.Core.Tests/Security/Certificates/ApplicationTestDataGenerator.cs Updates conditional compilation directive

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@romanett
Copy link
Contributor Author

@marcschier marcschier merged commit 4f4a0c9 into OPCFoundation:master Aug 26, 2025
76 of 77 checks passed
@romanett romanett deleted the feat/EnableLoggingForTests branch August 27, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants