-
Notifications
You must be signed in to change notification settings - Fork 1k
[Tests] Remove net 462 CI / Add TestContext Logging support for GDS Tests / Fix Tests for netstandard #3170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Remove net 462 CI / Add TestContext Logging support for GDS Tests / Fix Tests for netstandard #3170
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3170 +/- ##
==========================================
- Coverage 57.92% 57.49% -0.43%
==========================================
Files 351 353 +2
Lines 80471 80549 +78
Branches 14028 14037 +9
==========================================
- Hits 46611 46312 -299
- Misses 29561 29955 +394
+ Partials 4299 4282 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes .NET Framework 4.6.2 CI pipeline support and enhances test infrastructure by adding TestContext logging support for GDS tests and fixing netstandard compatibility issues.
- Removes the .NET 4.6.2 CI stage from azure-pipelines.yml
- Adds TestContext logging integration to GDS test infrastructure
- Updates conditional compilation directives from NET7_0_OR_GREATER to NET8_0_OR_GREATER for netstandard compatibility
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| azure-pipelines.yml | Removes .NET 4.6.2 CI test stage |
| Tests/Opc.Ua.Server.Tests/ReferenceServerTest.cs | Disables sampling groups in reference node manager |
| Tests/Opc.Ua.Gds.Tests/PushTest.cs | Adds TestContext.Out logging support to GDS test setup |
| Tests/Opc.Ua.Gds.Tests/GlobalDiscoveryTestServer.cs | Implements TestContext logging infrastructure with configurable log levels |
| Tests/Opc.Ua.Gds.Tests/Common.cs | Updates conditional compilation and adds TestContext writer parameter |
| Tests/Opc.Ua.Gds.Tests/ClientTest.cs | Integrates TestContext logging in client tests |
| Tests/Opc.Ua.Core.Tests/Types/Encoders/XmlEncoderTests.cs | Updates conditional compilation directive |
| Tests/Opc.Ua.Core.Tests/Types/Encoders/EncoderSpanExtensions.cs | Adds new extension methods for netstandard compatibility |
| Tests/Opc.Ua.Core.Tests/Security/Certificates/ApplicationTestDataGenerator.cs | Updates conditional compilation directive |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Proposed changes
Types of changes
Checklist