Update to 1.05.04 nodeset #3091

opcfoundation-org · 2025-06-17T07:38:31Z

Remove the unreleased nodeset from the codebase.

… to spec (#3053) (#3054) * Fix XML Encoding and decoding to conform to spec * fix test on linux * fix typo * Add missing DataValue & DiagnosticInfo Array Types Co-authored-by: romanett <romanett98@gmail.com>

Merge master into release/1.5.376

codecov · 2025-06-17T07:39:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.45%. Comparing base (a915f08) to head (7653719).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3091      +/-   ##
==========================================
+ Coverage   57.42%   57.45%   +0.02%     
==========================================
  Files         357      357              
  Lines       69113    69113              
  Branches    14201    14201              
==========================================
+ Hits        39686    39706      +20     
+ Misses      25178    25163      -15     
+ Partials     4249     4244       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mrsuciu · 2025-06-17T09:23:54Z

version.json

 {
  "$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
-  "version": "1.5.376-preview",
+  "version": "1.5.376",


Should remain 1.5.376-preview

mrsuciu · 2025-06-17T09:26:58Z

Stack/Opc.Ua.Core/Schema/SecuredApplication.cs

@@ -1,4 +1,5 @@
 #pragma warning disable 1591 
+#pragma warning disable 1591 


Duplicated pragma

mrsuciu · 2025-06-17T09:28:16Z

Stack/Opc.Ua.Core/Schema/SecuredApplication.cs

@@ -1,4 +1,5 @@
 #pragma warning disable 1591 
+#pragma warning disable 1591 
 //------------------------------------------------------------------------------


invisible character added

mrsuciu · 2025-06-17T09:28:51Z

Stack/Opc.Ua.Core/Schema/UANodeSet.cs

@@ -1,4 +1,5 @@
 #pragma warning disable 1591 
+#pragma warning disable 1591 


duplicate pragma and invisible character added

mrsuciu · 2025-06-17T09:41:29Z

Libraries/Opc.Ua.Gds.Server.Common/Model/Opc.Ua.Gds.Classes.cs

 using System.Collections.Generic;
 using System.Text;
 using System.Xml;
+using System.Linq;


mrsuciu · 2025-06-17T09:43:00Z

Stack/Opc.Ua.Core/Stack/Generated/Opc.Ua.Gds.DataTypes.cs

 using System.Collections.Generic;
 using System.Text;
 using System.Xml;
+using System.Linq;


romanett

This Breaks some CI Pipelines needs to be investigated If fixes are needed. Seems to be some issue with browse taking longer than usual probably because some underlying error that is catched, but slows down the operation significantly

romanett · 2025-06-19T10:53:58Z

Stack/Opc.Ua.Core/Schema/Opc.Ua.Gds.NodeSet2.xml

    <DisplayName>CertificateDirectoryType</DisplayName>
-    <Category>GDS Certificate Manager Pull Model</Category>
-    <Documentation>https://reference.opcfoundation.org/GDS/docs/7.9.2</Documentation>
+    <Category>GDS Certificate Manager CheckRevocationStatus</Category>


is this Category really correct?

romanett · 2025-06-19T10:55:30Z

Stack/Opc.Ua.Core/Stack/Generated/Opc.Ua.Classes.cs

        protected override int GetDefaultValueRank()
        {
-            return ValueRanks.Any;
+            return ValueRanks.Scalar;


is this related to an issue discussed before & a wanted cahnge?

yes - a change was made and then reversed because of fear of breaking code.

mrsuciu · 2025-06-19T16:17:01Z

Browse tests fail due to the circular references in the new Opc.Ua.PredefinedNodes.uanodes which cause an infinite browse loop:

Previous working version:

mrsuciu

Opc.Ua.PredefinedNodes.uanodes contains circular references which cause browse tests to fail see comment.
"Cosmetic" code changes highlighted.

mrsuciu and others added 5 commits April 11, 2025 16:09

Update version.json (#3050)

7586fd2

Fix XML Encoding and decoding of Matrix Element in Variant to conform…

f3f01d0

… to spec (#3053) (#3054) * Fix XML Encoding and decoding to conform to spec * fix test on linux * fix typo * Add missing DataValue & DiagnosticInfo Array Types Co-authored-by: romanett <romanett98@gmail.com>

Merge master into 1.5.376

9c11adf

Merge pull request #3087 from mrsuciu/merge-release/1.5.376

90faa62

Merge master into release/1.5.376

Return NodeSet to 1.05.04.

fa1257d

marcschier approved these changes Jun 17, 2025

View reviewed changes

mrsuciu reviewed Jun 17, 2025

View reviewed changes

romanett reviewed Jun 17, 2025

View reviewed changes

romanett reviewed Jun 19, 2025

View reviewed changes

mrsuciu requested changes Jun 19, 2025

View reviewed changes

randy-armstrong added 3 commits June 22, 2025 19:42

Remove OptionalPlaceholders on instances.

ab29740

Fix duplicate pragas.

df7f12f

Fix glitches in generated files.

7653719

romanett approved these changes Jun 23, 2025

View reviewed changes

mrsuciu approved these changes Jun 23, 2025

View reviewed changes

mrsuciu merged commit dcc02f1 into master Jun 23, 2025
120 checks passed

romanett deleted the update-to-1.05.04-nodeset branch August 12, 2025 13:50

		@@ -1,4 +1,5 @@
		#pragma warning disable 1591
		#pragma warning disable 1591

Update to 1.05.04 nodeset #3091

Update to 1.05.04 nodeset #3091

Uh oh!

Conversation

opcfoundation-org commented Jun 17, 2025

Uh oh!

codecov bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romanett left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrsuciu commented Jun 19, 2025

Uh oh!

mrsuciu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jun 17, 2025 •

edited

Loading

romanett left a comment •

edited

Loading