-
Notifications
You must be signed in to change notification settings - Fork 1k
Implement Support for PEM Public Keys in Directory Certificate Store #3088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…TStandard into feat/MultiplePEM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3088 +/- ##
==========================================
+ Coverage 57.42% 57.43% +0.01%
==========================================
Files 357 357
Lines 69117 69220 +103
Branches 14203 14222 +19
==========================================
+ Hits 39687 39756 +69
- Misses 25180 25198 +18
- Partials 4250 4266 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Stack/Opc.Ua.Core/Security/Certificates/DirectoryCertificateStore.cs
Outdated
Show resolved
Hide resolved
Tests/Opc.Ua.Security.Certificates.Tests/Assets/Test_keyPair.pem
Outdated
Show resolved
Hide resolved
mrsuciu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Proposed changes
This PR extends the directory store to check for PEM Public Keys (Up to 99 per file).
Private keys are also detected if they are in the same file or in the private folder.
If multiple Certs are contained in the same file, the file is deleted once no public keys are contained, also a private key file with the same name is removed once no Public keys are left.
PEMReader & PEMWriter are extended to deliver the needed functionality.
Tests are added for DirectoryStore & PEMReader.
Related Issues
Types of changes
Checklist
Further comments