Fix XML Encoding of Null Variant to conform to spec #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

mrsuciu merged 4 commits into OPCFoundation:master from romanett:fixVariant

May 23, 2025

Merged

Fix XML Encoding of Null Variant to conform to spec #3062

Update Encoder to Produce <uax:Value xsi:nil=\"true\" /> output

Annotations

10 warnings

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L656

The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'UaSCUaBinaryClientChannel.ProcessOpenSecureChannelResponse(uint, ArraySegment<byte>)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

Stack/Opc.Ua.Core/Types/Encoders/BinaryEncoder.cs#L596

Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L656

The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'UaSCUaBinaryClientChannel.ProcessOpenSecureChannelResponse(uint, ArraySegment<byte>)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

Stack/Opc.Ua.Core/Types/Encoders/BinaryEncoder.cs#L596

Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L656

The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'UaSCUaBinaryClientChannel.ProcessOpenSecureChannelResponse(uint, ArraySegment<byte>)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

Stack/Opc.Ua.Core/Types/Encoders/BinaryEncoder.cs#L596

Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265)

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L656

The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'UaSCUaBinaryClientChannel.ProcessOpenSecureChannelResponse(uint, ArraySegment<byte>)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L656

The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'UaSCUaBinaryClientChannel.ProcessOpenSecureChannelResponse(uint, ArraySegment<byte>)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L656

The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'UaSCUaBinaryClientChannel.ProcessOpenSecureChannelResponse(uint, ArraySegment<byte>)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L656

The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'UaSCUaBinaryClientChannel.ProcessOpenSecureChannelResponse(uint, ArraySegment<byte>)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

The logs for this run have expired and are no longer available.