Set default value for the ValueRank attribute of BaseVariableState and BaseVariableTypeState to ValueRanks.Any as in the specification #3049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default value for the ValueRank attribute of BaseVariableState and BaseVariableTypeState types and subtypes to ValueRanks.Any as specified in the specification.
Proposed changes
The default value used for the ValueRank attribute for BaseVariableState and BaseVariableTypeState type and subtype instances should be ValueRanks.Any. The attribute is omitted during serialization for efficiency purpose when the value is the default ValueRanks.Any, but must be set to the correct ValueRanks.Any value also when de-serialized in this specific case.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Many thanks to @saurla for finding the issue and providing valuable input and test case code.