Skip to content

Conversation

@mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Apr 10, 2025

Set default value for the ValueRank attribute of BaseVariableState and BaseVariableTypeState types and subtypes to ValueRanks.Any as specified in the specification.

Proposed changes

The default value used for the ValueRank attribute for BaseVariableState and BaseVariableTypeState type and subtype instances should be ValueRanks.Any. The attribute is omitted during serialization for efficiency purpose when the value is the default ValueRanks.Any, but must be set to the correct ValueRanks.Any value also when de-serialized in this specific case.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

Many thanks to @saurla for finding the issue and providing valuable input and test case code.

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.99%. Comparing base (7f037ef) to head (1c195c4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
+ Coverage   56.90%   56.99%   +0.08%     
==========================================
  Files         357      357              
  Lines       68900    68916      +16     
  Branches    14150    14154       +4     
==========================================
+ Hits        39207    39276      +69     
+ Misses      25488    25394      -94     
- Partials     4205     4246      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrsuciu mrsuciu merged commit 95d162e into OPCFoundation:master Apr 10, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataItemType and its sub types have incorrect ValueRank

2 participants