Add CAAM AEAD support #7116
Open
Add CAAM AEAD support #7116
+1,882
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce Sequence Fifo load command Signed-off-by: Olivier Masse <olivier.masse@nxp.com>
Introduce more CCB CLR WR register Signed-off-by: Olivier Masse <olivier.masse@nxp.com>
Add caam_cpy_buf_src() function that copy a data buffer into a caam buffer. Signed-off-by: Olivier Masse <olivier.masse@nxp.com>
|
CI reported some issues, I will update the pull request. |
Implement CAAM AES GCM CAAM Errata: When running GCM (not GMAC) when the IV is not 12 bytes (96 bits), it is possible to "roll over" the 32-bit counter value. When this occurs (unless counter starts at -1), the AES operation will generate an incorrect MAC. This occurs even when -1 is used as the counter for the last block. The problem is that the 32-bit counter will overflow into the h value, thus corrupting the MAC. In order to reliably work around this (unlikely) issue, the AES operation must be stopped after initialization to determine the counter value to see whether/when it will roll over. Then, before the offending block is processed, the context needs to be saved. The one block gets processed twice : GCM, restore MAC, GMAC over its ciphertext, then patch up the message and AAD lengths, and carry on as normal. Signed-off-by: Olivier Masse <olivier.masse@nxp.com> Signed-off-by: Sahil Malhotra <sahil.malhotra@nxp.com>
Implement CAAM AES CCM Signed-off-by: Olivier Masse <olivier.masse@nxp.com>
imx6dl-sabresd, imx6q-sabresd, imx6sx-sdb does not support AES GCM Signed-off-by: Olivier Masse <olivier.masse@nxp.com> Signed-off-by: Sahil Malhotra <sahil.malhotra@nxp.com>
sahilnxp
force-pushed
the
github_master_caam_aead
branch
from
04f50ab
to
2db2095
Compare
There has been an addition of CAAM AEAD driver, to include that need to update imx-mx8mmevk compilation command in case of se050 enabled Signed-off-by: Sahil Malhotra <sahil.malhotra@nxp.com>
sahilnxp
force-pushed
the
github_master_caam_aead
branch
from
2db2095
to
d05d2ef
Compare
|
CI reported issues taken case. |
| * @src_data Source to copy | ||
| * @src_length Length to copy | ||
| */ | ||
| enum caam_status caam_cpy_buf_src(struct caambuf *dst, uint8_t *src_data, |
There was a problem hiding this comment.
The _src suffix isn't needed in the function name.
| @@ -104,6 +104,17 @@ void caam_free_buf(struct caambuf *buf); | |||
| enum caam_status caam_cpy_block_src(struct caamblock *block, | |||
| struct caambuf *src, size_t offset); | |||
|
|
|||
| /* | |||
| * Copy source data into the buffer. Allocate buffer if | |||
| } | ||
|
|
||
| /* Do the copy */ | ||
| memcpy(dst->data, src_data, dst->length); |
There was a problem hiding this comment.
What if dst->length != src_length?
|
@sahilnxp, please add your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add support for CAAM AEAD support.
@omasse-linaro