Remove SQL-FS #86
Merged
Remove SQL-FS #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Apr 21, 2017
| * .cmd == OPTEE_MSG_RPC_CMD_SQL_FS and first parameter has the attribute | ||
| * OPTEE_MSG_ATTR_TYPE_VALUE_INPUT. | ||
| * Define protocol for messages with .cmd == OPTEE_MSG_RPC_CMD_FS and first | ||
| * parameter has the attribute OPTEE_MSG_ATTR_TYPE_VALUE_INPUT. |
There was a problem hiding this comment.
OPTEE_MSG_RPC_CMD_SQL_FS_RESERVED as optee_os conterpart.
etienne-lms
reviewed
Apr 21, 2017
tee-supplicant/src/tee_fs.h
Outdated
| @@ -69,8 +69,6 @@ struct tee_fs_rpc { | |||
| #define TEE_FS_RMDIR 13 | |||
| #define TEE_FS_ACCESS 14 | |||
| #define TEE_FS_LINK 15 | |||
There was a problem hiding this comment.
I would also keep those. Not mess API.
|
I'm also in favor of keeping the values as "reserved". |
Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro
force-pushed
the
rem_sqlfs
branch
from
3beaa28
to
403c9a1
Compare
|
Comments addressed, rebased, tag applied. |
etienne-lms
added a commit
to etienne-lms/optee_client
that referenced
this pull request
Jan 31, 2020
Library ckteec will implement the PKCS#11 API using the PKCS11 trusted application executing in OP-TEE as backend token. Implement pkcs11.h header file that partially covers the PKCS#11 specification. Resources initially planned to be supported are defined. The header will need to be updated with remaining PKCS#11 definition when related support will be implemented. Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> Check patch issues: ERROR: need consistent spacing around '*' (ctx:WxV) OP-TEE#86: FILE: libckteec/include/pkcs11.h:29: +typedef CK_BYTE *CK_BYTE_PTR; ^ WARNING: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary OP-TEE#48: FILE: libckteec/include/pkcs11.h:22: +typedef unsigned long int CK_ULONG; ERROR: "foo * bar" should be "foo *bar" OP-TEE#60: FILE: libckteec/include/pkcs11.h:34: +typedef void * CK_VOID_PTR; WARNING: do not add new typedefs #424: FILE: libckteec/include/pkcs11.h:398: +typedef struct CK_AES_CBC_ENCRYPT_DATA_PARAMS CK_AES_CBC_ENCRYPT_DATA_PARAMS; WARNING: space prohibited between function name and open parenthesis '(' #693: FILE: libckteec/include/pkcs11.h:667: +typedef CK_RV (* CK_NOTIFY)(CK_SESSION_HANDLE hSession, ERROR: space prohibited after that '*' (ctx:BxW) #693: FILE: libckteec/include/pkcs11.h:667: +typedef CK_RV (* CK_NOTIFY)(CK_SESSION_HANDLE hSession, WARNING: Missing a blank line after declarations #708: FILE: libckteec/include/pkcs11.h:682: + CK_VERSION version; + CK_RV (*C_Initialize)(CK_VOID_PTR pInitArgs); WARNING: space prohibited between function name and open parenthesis '(' #712: FILE: libckteec/include/pkcs11.h:686: + CK_RV (*C_GetSlotList)(CK_BBOOL tokenPresent,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org
Depends on OP-TEE/optee_os#1490