libckteec: Fix X.509 certificate attribute handlings #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2021
etienne-lms
reviewed
Oct 1, 2021
CKA_NAME_HASH_ALGORITHM is CK_ULONG and needs to be translated to 32bits. Signed-off-by: Vesa Jääskeläinen <vesa.jaaskelainen@vaisala.com> Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
CKA_CERTIFICATE_CATEGORY is CK_ULONG and needs to be translated to 32bits. Signed-off-by: Vesa Jääskeläinen <vesa.jaaskelainen@vaisala.com> Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
We should return CKR_ATTRIBUTE_VALUE_INVALID to indicate that value is incorrect. CKR_ATTRIBUTE_TYPE_INVALID is used to indicate that unknown attribute was provided. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 4.1.1 Creating objects "2. If the supplied template specifies an invalid value for a valid attribute, then the attempt should fail with the error code CKR_ATTRIBUTE_VALUE_INVALID." Signed-off-by: Vesa Jääskeläinen <vesa.jaaskelainen@vaisala.com> Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
vesajaaskelainen
force-pushed
the
pkcs11-x509-cert-fixes
branch
from
bb996e0
to
40a3df9
Compare
Thanks for the review. Tags applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CK_ULONG conversion was forgotten on first batch so this adds them.
Also fixes error value returned when provided CK_ULONG value is too small.
Relates to:
Related PRs: