Changes to allow DB configuration and scaling #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tej99
reviewed
Jun 11, 2018
| @@ -1,6 +1,8 @@ | |||
| package uk.gov.ons.ctp.response.sample; | |||
|
|
|||
| import net.sourceforge.cobertura.CoverageIgnore; | |||
|
|
|||
| import org.apache.tomcat.jdbc.pool.DataSource; | |||
tej99
reviewed
Jun 11, 2018
.checkstyle
Outdated
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 62.42% 62.42%
=======================================
Files 24 24
Lines 503 503
Branches 45 45
=======================================
Hits 314 314
Misses 180 180
Partials 9 9Continue to review full report at Codecov.
|
…thub.com/ONSdigital/rm-sample-service into performance-improvement-1300-concurrency
VibhorMehra
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
It turns out that the database parameters in application-cloud.yml are overridden by CloudFoundry. This changes that!
What has changed
DataSourceConfigurationhas been added which forces Spring Boot to use the config rather than CloudFoundry's one from buildpacksHow to test?
You'll need to push to CloudFoundry to see the impact of these changes. The easiest way is to set
spring.datasource.tomcat.max-idleto a higher number thanmax-active; this will cause Spring Boot to log out a message just after the service starts that max-idle is higher than max-active and give you the figures in the .yml. If it says it's setting it to 4, it's broken (these are the defaults CF was injecting)