This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Add equals and hashcode method #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding config pom and xsd plugin to generate equals and hashcode method
benjefferies
approved these changes
Jun 5, 2018
benjefferies
requested review from
madeye-matt,
davidmort,
mfcrocker,
JamesGardiner,
emilioward,
liamtoozer and
jcox-dev
tej99
approved these changes
Jun 7, 2018
benjefferies
pushed a commit
to ONSdigital/rm-sample-service
that referenced
this pull request
Jun 11, 2018
Social files currently have four required attribute fields and can contain an arbitrary number of non mandatory attributes. The attributes are described by a header row in the sample file. Adds functionality to parse a social sample file, persist sample attributes and post attributes to collection exercise. When a file is uploaded it is parsed and validated. If valid, it will be saved to a sample attributes table in the sample database linked by the sample unit id (UUID). When a request is made for samples the sample unit and sample attributes and put on the sample delivery queue. We have added integration tests to exercise the upload functionality and ensure they are published to the queue with the sample attributes. **How to test:** Requires changes in these branches: ONSdigital/rm-samplesvc-api#11 ONSdigital/rm-party-service-api#11 You'll have to build them locally then point the pom file to those snapshots, this will block Travis from building until those changes are on master. Try loading a social sample through the endpoint using the loader script: #45 You should also try the loader script with a full example sample file, there is one available as an attachment on the story card:  [Dev task 1: INT: load a social sample file (13)](https://trello.com/c/lTUmPnuf/97-dev-task-1-int-load-a-social-sample-file-13) Also requires these changes before being merged: ONSdigital/rm-samplesvc-api#9 #42
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding config pom and xsd plugin to generate equals and hashcode method
Required for ONSdigital/rm-sample-service#44