Skip to content

Conversation

@ldavies99
Copy link
Contributor

@ldavies99 ldavies99 commented Sep 23, 2025

Proposed Changes

Related Issues

Pre-requisites

This section may not be fully required if the branch is not merging into main.
Please indicate items that aren't necessary and why, with comments around incomplete checks.

  • Version number has been incremented, according to SemVer
  • Changelog has been updated, listing changes to this version. Use the keep a changelog format
  • New features are tested
  • New features are documented using the numpydoc docstring format
  • Other relevant package documentation is updated
  • For new functionality, examples are included in the docs or a feature request has
    been made for it/them.

@ldavies99 ldavies99 self-assigned this Sep 23, 2025
@ldavies99
Copy link
Contributor Author

If you run pytest on the branch, you can compare the actual_workbook.xlsx and expected_workbook.xlsx under gptables/test/ to see the affects of the changes.

@ldavies99 ldavies99 linked an issue Sep 29, 2025 that may be closed by this pull request
@ellie-o ellie-o requested review from addledrabbit and removed request for gisellerosetta October 1, 2025 09:08
@addledrabbit
Copy link
Contributor

Will pick this review up when I’m back from A/L on Wednesday.

@gisellerosetta gisellerosetta requested review from Sara-Jade-O and removed request for addledrabbit October 13, 2025 09:43
Copy link

@Sara-Jade-O Sara-Jade-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated logic looks good to me - happy to merge

@Sara-Jade-O Sara-Jade-O merged commit 023b7ae into dev Oct 13, 2025
11 of 12 checks passed
@gisellerosetta gisellerosetta deleted the 155-an-alternative-approach-for-auto-column-widths branch October 13, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auto_width sets 0 widths for non-string type column headers

4 participants