Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prod users seeing a dynamic import error #3808

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)

What is the current behavior?

A user reported this issue when clicking onto a how-to:
dynam-eror

What is the new behavior?

From reading this, a possible reason for the issue is that our prod hosting provider deletes the old js files that the new build links to.

My fix causes a page level refresh (to get the most up to date js files) when that error occurs.

@benfurber benfurber requested a review from a team as a code owner July 30, 2024 10:16
Copy link

cypress bot commented Jul 30, 2024



Test summary

66 0 1 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit ada9447
Started Jul 30, 2024 10:24 AM
Ended Jul 30, 2024 10:28 AM
Duration 04:01 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@benfurber benfurber merged commit 977b6f3 into ONEARMY:master Jul 30, 2024
19 checks passed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.205.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@benfurber benfurber deleted the fix/dynamic-import-failure branch October 22, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants