-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding in function to have separate cohorts or combine them together for package #64
Comments
Also does the package make sure that we have unique entries when combining cohorts? ie one record per person when combining cohorts otherwise there might a patient might contribute multiple times? |
Regarding point above when you create a cohort with multiple ingredients it will take the first one of all the ingredients combined - therefore only 1 person contributes. However when you run each ingredient there is a chance if a person has been prescribed different ingredients from the same class meaning that a person could contribute to multiple times. @xihang-chen and I discussed this and think if users want to make sure each cohort of ingredients only have 1 person per class of ingredients but to then run PSSA at the ingredient level then users can group_by and add a filter to only keep the first ingredient they are prescribed from a class/group of user specfied ingredients. So meaning this is a user problem not a package problem |
@catalamarti if i use generateIngredientCohortSet this creates a cohort but there are 3 cohort_definition_ids one for each anti-dementia drug but what i want is a cohort with these specific ingrediants in them..but i dont think binding them will work because what if i have patients who are taking two of the medications then they would be duplicated(?)
so the only thing i think that works is this:
Would you do it this way? any other suggestions would be greatly appreciated :) on the plus side as payment there are some sweets on my desk by Marta she will show you :) |
At the moment a user has to instanstiate each drug of interest for cohort symmetry but what if a user wants to combine different drugs cohorts together in one cohort as well as test them individually. Example is dementia medications there are two types 1) Ache inhibitors (three ingrediants) and 2) memantine. I want to run cohortsymmetry with Ache inhibitors with all three ingrediants together as well as them indivdually against my marker drugs of choice. @xihang-chen suggested including an argument in the getSequenceRatio() which gives the user flexibility to do this.
The text was updated successfully, but these errors were encountered: