Fix parsing issue for Flags enum values with combined flags #3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/AzurePipelines run |
|
No pipelines are associated with this pull request. |
|
/AzurePipelines run |
|
No pipelines are associated with this pull request. |
WanjohiSammy
requested review from
xuzhg,
ElizabethOkerio,
habbes and
gathogojr
and removed request for
xuzhg
WanjohiSammy
force-pushed
the
fix/3244-support-flags-enum
branch
from
8e03a95 to
2bfab4c
Compare
|
/AzurePipelines run |
|
No pipelines are associated with this pull request. |
gathogojr
reviewed
Sep 10, 2025
gathogojr
reviewed
Sep 10, 2025
gathogojr
reviewed
Sep 10, 2025
gathogojr
reviewed
Sep 10, 2025
|
/AzurePipelines run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes
Description
OData queries fail when filtering against Flags enum properties using combined enum values, whether specified as string representations (
'Premium,Loyal') or numeric equivalents (66).The current implementation in
MetadataBindingUtils.csdoes not properly handle:Changes Made
Query Patterns Now Supported
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.
Repository notes
Team members can start a CI build by adding a comment with the text
/AzurePipelines runto a PR. A bot may respond indicating that there is no pipeline associated with the pull request. This can be ignored if the build is triggered.Team members should not trigger a build this way for pull requests coming from forked repositories. They should instead trigger the build manually by setting the "branch" to
refs/pull/{prId}/mergewhere{prId}is the ID of the PR.