Fix security vulnerabilities in Newtonsoft.Json and System.Data.SqlClient #2876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/AzurePipeline run |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates key dependencies to address known security vulnerabilities in JSON handling and SQL connectivity.
- Adds
System.Data.SqlClientv4.9.0 to the end-to-end test project - Adds
Newtonsoft.Jsonv13.0.1 to the main OData project
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/E2ETest/Microsoft.Test.E2E.AspNet.OData/Build.AspNetCore3x/Microsoft.Test.E2E.AspNetCore3x.OData.csproj | Added System.Data.SqlClient v4.9.0 for SQL tests |
| src/Microsoft.AspNetCore.OData/Microsoft.AspNetCore.OData.csproj | Added Newtonsoft.Json v13.0.1 for JSON serialization |
Comments suppressed due to low confidence (3)
test/E2ETest/Microsoft.Test.E2E.AspNet.OData/Build.AspNetCore3x/Microsoft.Test.E2E.AspNetCore3x.OData.csproj:33
- No new tests verify the integrated SQL client behavior against the patched version; consider adding or updating tests to cover the resolved CVE scenarios.
<PackageReference Include="System.Data.SqlClient" Version="4.9.0" />
test/E2ETest/Microsoft.Test.E2E.AspNet.OData/Build.AspNetCore3x/Microsoft.Test.E2E.AspNetCore3x.OData.csproj:33
- [nitpick] Consider adding PrivateAssets="All" to this test-only PackageReference so that transitive dependencies are not exposed to consuming projects.
<PackageReference Include="System.Data.SqlClient" Version="4.9.0" />
src/Microsoft.AspNetCore.OData/Microsoft.AspNetCore.OData.csproj:46
- [nitpick] If this package is only used internally, consider adding PrivateAssets or ExcludeAssets attributes to avoid unintended exposure of the JSON library to downstream consumers.
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #xxx.
Description
This PR handles multiple known security vulnerabilities by updating or patching affected dependencies. The following CVEs are resolved:
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.