Custom method can now have nullable parameters and nullable arguments #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
reviewed
Nov 13, 2023
src/Microsoft.AspNetCore.OData/Query/Expressions/QueryBinder.SingleValueFunctionCall.cs
Show resolved
Hide resolved
…nctionCall in wrong method
KenitoInc
requested review from
ElizabethOkerio,
KenitoInc,
corranrogue9,
gathogojr,
habbes and
mikepizzo
|
Please add a description to what the pr does. |
|
Please add some test to this Pr |
Contributor
Author
|
@xuzhg I know this PR is old but it is still relevant |
xuzhg
approved these changes
Dec 12, 2024
Member
xuzhg
left a comment
xuzhg
left a comment
There was a problem hiding this comment.
Will you port it to latest main branch for 9.x version?
Contributor
Author
@xuzhg Yes, but should I not complete this PR first and then cherry pick the commit and create a PR to main? I am unable to complete this PR due to the AspNetCoreOData-main-rolling-1ES Azure Pipeline has not been triggered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084
This PR will make it possible to create custom function for nullable types.